[PATCH] D17334: [mips][microMIPS] Implement MFC*, MFHC* and DMFC* instructions

Simon Dardis via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 19 04:55:45 PST 2016


sdardis added a subscriber: sdardis.
sdardis added a comment.

As with http://reviews.llvm.org/D17328, dmfc2 taking a selector is awaiting clarification.


================
Comment at: test/MC/Mips/mips64r5/invalid.s:19
@@ +18,3 @@
+        dmfc0  $4, $3, 8     # CHECK: :[[@LINE]]:24: error: expected 3-bit unsigned immediate
+        dmfc2  $4, $3, -1    # CHECK: :[[@LINE]]:24: error: expected 3-bit unsigned immediate
+        dmfc2  $4, $3, 8     # CHECK: :[[@LINE]]:24: error: expected 3-bit unsigned immediate
----------------
Issue here, dmfc2 does not appear to actually take a selector. I'm waiting on clarification from the documents group.


http://reviews.llvm.org/D17334





More information about the llvm-commits mailing list