[PATCH] D16689: [tsan] Dynamically detect heap range for aarch64.

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 9 01:45:11 PST 2016


rengolin requested changes to this revision.
rengolin added a reviewer: rengolin.
rengolin added a comment.
This revision now requires changes to proceed.

In http://reviews.llvm.org/D16689#346952, @kcc wrote:

> This change also introduces more instructions on the main path . 
>  From reading the patch it seems to be AArch64-specific, so I am fine with that,


I'm not. :)

AArch64 already suffers from bloat from the VMA selection, adding more main path run time slow down is not the way to go, especially when that involved division and multiplication.

Also, these sources are outdated, the AArch64 part is not like that any more for a good number of months.

cheers,
--renato


http://reviews.llvm.org/D16689





More information about the llvm-commits mailing list