[PATCH] D16689: [tsan] Dynamically detect heap range for aarch64.

[Kostya Serebryany via llvm-commits]

kcc added a comment.

> > mapping[256];

> 


I have not touched tsan for a while, but if my understanding is still correct an extra load on fast path may cost us 10%  of CPU. 
That's too much. 
Don't do it unless you really have to, and get perf numbers before sending such a CL.

This change also introduces more instructions on the main path . 
>From reading the patch it seems to be AArch64-specific, so I am fine with that, 
but I'd like to have the new functions like MemToShadowImplWithDynamicHeap to be under ifdef AArch64, 
so that they can not be possibly used for x86


================
Comment at: lib/tsan/rtl/tsan_platform.h:609
@@ +608,3 @@
+  DCHECK(IsAppMem(x));
+#ifndef SANITIZER_GO
+  if (x >= Mapping::kHeapMemBeg &&
----------------
Here and below, can we use if (SANITIZER_GO) instead of #ifdef? 


http://reviews.llvm.org/D16689