[PATCH] D16908: [ValueTracking] Use Constant::isZeroValue() in isKnownZero()

Jun Bum Lim via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 5 07:50:41 PST 2016

junbuml added a comment.

> This makes sense to me. But I'm curious if you've seen any changes with this because it doesn't look to be functionally identical, due to the extra floating point checking done in isZeroValue. While you're here, it would be nice to fix the comment for the function to mention the constants.

I am sending this out to get any early feedback. Since this is not a NFC, I need to check performance. This is also missing test cases that I will add soon.


More information about the llvm-commits mailing list