[PATCH] D16908: [ValueTracking] Use Constant::isZeroValue() in isKnownZero()

Matthew Simpson via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 5 07:33:16 PST 2016


mssimpso added a subscriber: mssimpso.
mssimpso added a comment.

Jun,

This makes sense to me. But I'm curious if you've seen any changes with this because it doesn't look to be functionally identical, due to the extra floating point checking done in isZeroValue. While you're here, it would be nice to fix the comment for the function to mention the constants.


http://reviews.llvm.org/D16908





More information about the llvm-commits mailing list