Re: [PATCH] D16251: There seems to be a fundamental problem in SimplifyCFG: Dead code removal can result inuninitialized variables. The impact is an “endless” loop which can be consideredthe consequence of searching for the initialization. More details are...
Gerolf Hoflehner via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 2 20:45:36 PST 2016
Gerolf added a comment.
Thank you Akira and Philip. I agree with your concerns that using a stale dominator information could at some end up in a situation where the current implementation might not prevent a similar bug. For now I provided a simpler fix for the endless loop problem in http://reviews.llvm.org/D16839. Please take a look at that. In case there is a more systemic problem in SimplifyCFG that requires dominance in this scenario I think the best approach is to compute all blocks dominated by a block B on the fly. This can be done for example in 3 passes over all blocks reachable from B.
More information about the llvm-commits