[PATCH] D16734: [AArch64] Simplify prolog/epilog callee save/restore. NFC.

George Burgess IV via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 1 09:59:40 PST 2016

george.burgess.iv added inline comments.

Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:687
@@ -680,3 +686,3 @@
   for (unsigned i = 0; i < Count; i += 2) {
     unsigned idx = Count - i - 2;
gberry wrote:
> george.burgess.iv wrote:
> > It seems that you always add `Count/2` elements to `RegPairs`. Is there any harm in reserving this amount of space in `RegPairs` ahead of time?
> The number of RegPairs added is going to change in my next patch (and be less predictable up front), so I'm not sure this makes sense.  It will still be possible to reserve an upper bound in the next change (with the possibility of not using all of the reserved space).  Do you still think this is worth doing in light of that?
Ah, if the result size isn't going to be basically handed to us for free, then I agree with you that it's probably better to not resize upfront. :)


More information about the llvm-commits mailing list