[PATCH] D15412: [SCEV][LAA] Add no overflow SCEV predicates and use use them to improve strided pointer detection

silviu.baranga@arm.com via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 1 05:16:56 PST 2016


sbaranga added a comment.

In http://reviews.llvm.org/D15412#336209, @anemet wrote:

> Hi Silviu,
>
> Just started to look at this (sorry about the delay) and on first impression, I am surprised by the lack of tests.  Can't we cover this with LAA tests?
>
> Adam


Hi Adam,

I've been having some trouble testing this with just LAA (we were bailing out when checking if we can do runtime checks).
However, I can now trigger this by adding noalias on the input pointers, so that problem has been solved and I can trigger all code paths with LAA.

I'll also need your change for loop versioning testing (http://reviews.llvm.org/D16612) in order to test the runtime checks, so I'll wait for that to go in before updating this.

Thanks,
Silviu


http://reviews.llvm.org/D15412





More information about the llvm-commits mailing list