[PATCH] D13087: A fix for loop vectorizer with handling loops with volatile induction variables

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 1 04:55:57 PST 2016


hfinkel added a comment.

As noted, please add some comments to the header-file function description, otherwise looks good.


================
Comment at: include/llvm/Transforms/Utils/Local.h:139
@@ -137,3 +138,3 @@
 /// the basic block that was pointed to.
 ///
 bool SimplifyCFG(BasicBlock *BB, const TargetTransformInfo &TTI,
----------------
I don't see any changes to the comments here describing the LoopHeaders parameter.

================
Comment at: lib/Transforms/Utils/SimplifyCFG.cpp:4935
@@ -4920,2 +4934,3 @@
 
+
   // If the only instruction in the block is a seteq/setne comparison
----------------
Don't add an extra new line here.


Repository:
  rL LLVM

http://reviews.llvm.org/D13087





More information about the llvm-commits mailing list