[PATCH] D16371: [compiler-rt/profile] Added Hostname to .profdata file

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 28 18:10:59 PST 2016

hfinkel added a comment.

In http://reviews.llvm.org/D16371#338901, @vsk wrote:

> To clarify, my objection to using guards for this feature wasn't cosmetic: is there anything fundamental about MSVC that inhibits this feature?

There's no uname() (or sys/utsname.h) on Windows. That's a POSIX function.

> I see that your lit test tests this patch, but (1) am concerned that the usage of uname might break Windows bots, and

It would, except that the '// REQUIRES: shell' should cause the Windows bots to skip the test.

> (2) wonder whether uname can be used by your scripts directly instead of relying on %h-expansion.

It is not clear how else to test that the host-name expansion actually works.


More information about the llvm-commits mailing list