[PATCH] D16371: [compiler-rt/profile] Added Hostname to .profdata file

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 28 17:44:08 PST 2016

vsk added a comment.

To clarify, my objection to using guards for this feature wasn't cosmetic: is there anything fundamental about MSVC that inhibits this feature?

I see that your lit test tests this patch, but (1) am concerned that the usage of uname might break Windows bots, and (2) wonder whether uname can be used by your scripts directly instead of relying on %h-expansion.


More information about the llvm-commits mailing list