[PATCH] D16530: [Polly] Introduce MemAccInst helper class; NFC

Mailing List "llvm-commits" via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 25 06:58:22 PST 2016

llvm-commits added a comment.

> +/// getValueOperand() and getPointerOperand() have different implementations in

>  +/// LoadInst and StoreInst, but for most other members the implementation is

>  +/// identical. Those have been reproduced here to avoid useless branching to

>  +/// identical implementations. If those implementations change in

>  +/// LoadInst/StoreInst, they must be changed here as well.

The last sentence alone guarantees problems. Duplication is (almost)
never a solution, especially not to save a call/jump/branch.

- F1366146: signature.asc <http://reviews.llvm.org/F1366146>
- F1366145: msg-5106-603.txt <http://reviews.llvm.org/F1366145>


More information about the llvm-commits mailing list