[PATCH] D16530: [Polly] Introduce MemAccInst helper class; NFC

Johannes Doerfert via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 25 06:47:45 PST 2016

> +/// getValueOperand() and getPointerOperand() have different implementations in
> +/// LoadInst and StoreInst, but for most other members the implementation is
> +/// identical. Those have been reproduced here to avoid useless branching to
> +/// identical implementations. If those implementations change in
> +/// LoadInst/StoreInst, they must be changed here as well.
The last sentence alone guarantees problems. Duplication is (almost)
never a solution, especially not to save a call/jump/branch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 213 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160125/6126e78e/attachment.sig>

More information about the llvm-commits mailing list