[PATCH] D16196: [test-suite] Add HOME to test env under lit

Chris Matthews via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 14 11:30:42 PST 2016


We have found that some benchmarks will differ their performance based on the sizes of the environment variables.  KS is a good example of this.  Is there a better way to do this than populating the environment?

> On Jan 14, 2016, at 11:21 AM, Matthias Braun via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> MatzeB accepted this revision.
> MatzeB added a comment.
> This revision is now accepted and ready to land.
> 
> LGTM. Could be refactored to something like the following though:
> 
>  environment_whitelist = ['HOME', 'SSH_AUTH_SOCK']
>  for var in environment_whitelist:
>    if var in os.environ:
>      config.environment[var] = os.environ[var]
> 
> 
> http://reviews.llvm.org/D16196
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list