[PATCH] D16196: [test-suite] Add HOME to test env under lit

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 14 11:42:53 PST 2016


MatzeB added a comment.

In http://reviews.llvm.org/D16196#327205, @llvm-commits wrote:

> We have found that some benchmarks will differ their performance based on the sizes of the environment variables.  KS is a good example of this.  Is there a better way to do this than populating the environment?


Very good point!

Maybe we should be more conservative and force people to configure the environment variables in the cmake configuration and use an empty env by default?

(Though I must admit if we start thinking about these issues: I think the directory of the testsuite matters as well because that ends up being in argv[0] and cmake/lit currently uses absolute paths wherever possible)


http://reviews.llvm.org/D16196





More information about the llvm-commits mailing list