[PATCH] D16004: Increase use of svr4 packets to improve performance on POSIX remotes

Aidan Dodds via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 11 09:43:25 PST 2016


ADodds added inline comments.

================
Comment at: include/lldb/Core/LoadedModuleInfoList.h:99
@@ +98,3 @@
+
+        bool has_info (e_data_point datum)
+        {
----------------
can also be made const.

================
Comment at: include/lldb/Core/LoadedModuleInfoList.h:108
@@ +107,3 @@
+        {
+            return (m_base == rhs.m_base) &&
+                   (m_link_map == rhs.m_link_map) &&
----------------
Should we be checking the m_has fields here when making each comparison?


http://reviews.llvm.org/D16004





More information about the llvm-commits mailing list