[PATCH] D16004: Increase use of svr4 packets to improve performance on POSIX remotes

[Aidan Dodds via llvm-commits]

ADodds added inline comments.

================
Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp:289
@@ +288,3 @@
+        // Only add shared libraries and not the executable.
+        if (!SOEntryIsMainExecutable(entry)) {
+            m_soentries.push_back(entry);
----------------
As a nitpick there seems to be inconsistent use of { on the same line and on a new line.  For lldb it should really be placed on a new line.

================
Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp:405
@@ -234,3 +404,3 @@
 bool
 DYLDRendezvous::UpdateSOEntriesForAddition()
 {
----------------
If your adding AddSOEntriesFromRemote() should the above function be renamed to AddSOEntries() for consistency?


================
Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp:436
@@ -265,3 +435,3 @@
 bool
 DYLDRendezvous::UpdateSOEntriesForDeletion()
 {
----------------
If your adding RemoveSOEntriesFromRemote() should the above function be renamed to RemoveSOEntries() for consistency?


http://reviews.llvm.org/D16004