[PATCH] D15189: [tsan] Introduce a "ignore_interceptors_accesses" option

Kuba Brecka via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 9 10:22:03 PST 2016


kubabrecka added inline comments.

================
Comment at: lib/tsan/rtl/tsan_interceptors.cc:2155
@@ -2150,2 +2154,3 @@
   }
+  SCOPED_TSAN_INTERCEPTOR_USER_CALLBACK_START();
   int res = REAL(pthread_kill)(tid, sig);
----------------
dvyukov wrote:
> Why is this a user callback?
It ends up calling ThreadFinalize, which expects ignores to be disabled (check that ignore_reads_and_writes==0).  Suggestions to handle this better?


http://reviews.llvm.org/D15189





More information about the llvm-commits mailing list