[PATCH] D15189: [tsan] Introduce a "ignore_interceptors_accesses" option

Dmitry Vyukov via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 9 07:00:42 PST 2016


dvyukov added inline comments.

================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:3311
@@ -3301,2 +3310,3 @@
   REAL(_exit)(status);
+  COMMON_INTERCEPTOR_USER_CALLBACK_END();
 }
----------------
I think you need to put it before REAL(_exit), because it is no-return. Though, it is probably don't matter much.

================
Comment at: lib/tsan/rtl/tsan_interceptors.cc:2155
@@ -2150,2 +2154,3 @@
   }
+  SCOPED_TSAN_INTERCEPTOR_USER_CALLBACK_START();
   int res = REAL(pthread_kill)(tid, sig);
----------------
Why is this a user callback?


http://reviews.llvm.org/D15189





More information about the llvm-commits mailing list