HA: [PATCH] D15480: [ELF][MIPS] Handle R_MIPS_HI16/LO16 relocations against _gp_disp symbol

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 24 03:22:40 PST 2015

>>I thinking about that place last time.
>>May be we should add A argument to Target->relocateOne()  ?
>>That can help to move that calculation to mips target, since it looks like absence of A inside relocateOne() is the only stoppable for doing that.
>Currently S+A is a single parameter SA. Are you suggesting split that as two parameters, S and A?
>I don't know if that makes code simpler, but it may worth trying.

Not sure about splitting. That seems to be more complicated. Just adding A can save from complicating logic outside allowing relocateOne to use it if it is needed for concrete relocation`s code like here for mips.

More information about the llvm-commits mailing list