[PATCH] D15480: [ELF][MIPS] Handle R_MIPS_HI16/LO16 relocations against _gp_disp symbol
Rui Ueyama via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 24 03:12:18 PST 2015
On Thu, Dec 24, 2015 at 8:04 PM, George Rimar <grimar at accesssoftek.com>
> grimar added a subscriber: grimar.
> Comment at: lld/trunk/ELF/InputSection.cpp:213
> @@ -208,2 +212,3 @@
> + SymVA = getMipsGpAddr<ELFT>() - AddrLoc + 4;
> uintX_t A = getAddend<ELFT>(RI);
> I thinking about that place last time.
> May be we should add A argument to Target->relocateOne() ?
> That can help to move that calculation to mips target, since it looks like
> absence of A inside relocateOne() is the only stoppable for doing that.
Currently S+A is a single parameter SA. Are you suggesting split that as
two parameters, S and A?
I don't know if that makes code simpler, but it may worth trying.
> rL LLVM
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits