[PATCH] D15757: Extract helper function to merge MemoryOperand lists [NFC]

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 23 15:46:06 PST 2015

reames added inline comments.

Comment at: include/llvm/CodeGen/MachineInstr.h:1186
@@ -1187,1 +1185,3 @@
+  /// Assign this MachineInstr's memory reference descriptor list.  First
+  /// element in the pair is the begin iterator/pointer to the array; the
sanjoy wrote:
> Why `std::pair` (as opposed to two separate arguments)?
Because it groups the array descriptor (base, and length) into a single value. It also allows me to write setMemRefs(I->mergeMemRefsWith(*I2)) which wouldn't be possible otherwise. 


More information about the llvm-commits mailing list