[PATCH] D15757: Extract helper function to merge MemoryOperand lists [NFC]

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 23 15:42:52 PST 2015

sanjoy added a comment.

Minor drive-by comments.

Comment at: include/llvm/CodeGen/MachineInstr.h:1186
@@ -1187,1 +1185,3 @@
+  /// Assign this MachineInstr's memory reference descriptor list.  First
+  /// element in the pair is the begin iterator/pointer to the array; the
Why `std::pair` (as opposed to two separate arguments)?

Comment at: include/llvm/CodeGen/MachineInstrBuilder.h:165
@@ -164,1 +164,3 @@
+  const MachineInstrBuilder &setMemRefs(std::pair<MachineInstr::mmo_iterator, unsigned> MemOperandsRef) const {
+    MI->setMemRefs(MemOperandsRef);
Please double check, but this line looks like it is too long.

(I'd just run `clang-format` on the diff before checking in)


More information about the llvm-commits mailing list