[llvm] r254592 - Fix class SCEVPredicate has virtual functions and accessible non-virtual destructor.

Andy Gibbs via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 17 08:55:43 PST 2015

On Thursday, December 17, 2015 6:10 AM, David Blaikie wrote:
> On Wed, Dec 16, 2015 at 9:53 PM, Andy Gibbs wrote:
>> I'd like to see how that pans out before making this change.  I hope 
>> that's ok?  :o)
> Sure - I've commented on the bug - not sure if anyone else will
> (hopefully they do), so I'm not sure what definition of "pans out"
> might be applicable if the bug languishes in the database without
> any specific attention. (as bugs often do)

Don't worry - its handled in r255905 (hopefully not breaking any buildbots 
on the way).

I additionally improved the handling of warning switches 
(-Wdelete-non-virtual-dtor is no in there now and -Wnon-virtual-dtor is not 
for gcc builds only).  I will also close out the bug -- it is true that I 
had only used the -Wnon-virtual-dtor warning in my testing and had not 
realised that the other warning existed!!

Cheers, and thanks for your patience.


More information about the llvm-commits mailing list