[llvm] r254592 - Fix class SCEVPredicate has virtual functions and accessible non-virtual destructor.

[David Blaikie via llvm-commits]

On Wed, Dec 16, 2015 at 9:53 PM, Andy Gibbs <andyg1001 at hotmail.co.uk> wrote:

> On Thursday, December 03, 2015 8:15 PM, David Blaikie wrote:
>
>> Sure sure, no rush.
>>
>
> I didn't forget, but its been a busy couple of weeks and I didn't have a
> chance to look into this again until today.  I have made a patch to revert
> the change and to the CMake files to remove (actually not enable) the
> warning for gcc.  However, I have done a little playing around to find the
> limits of the clang diagnostic and it doesn't correctly identify the
> non-virtual dtor inside a friend function. I've stuck a bug-report up here:
> https://llvm.org/bugs/show_bug.cgi?id=25850


> I'd like to see how that pans out before making this change.  I hope
> that's ok?  :o)
>

Sure - I've commented on the bug - not sure if anyone else will (hopefully
they do), so I'm not sure what definition of "pans out" might be applicable
if the bug languishes in the database without any specific attention. (as
bugs often do)

- Dave


>
> Cheers
> Andy
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151217/53ae1d27/attachment.html>