[PATCH] D15464: Add a C++11 ThreadPool implementation in LLVM

[Mehdi Amini via llvm-commits]

> On Dec 13, 2015, at 4:30 PM, David Blaikie <dblaikie at gmail.com> wrote:
> 
> 
> 
> On Sat, Dec 12, 2015 at 2:58 PM, Mehdi AMINI via llvm-commits <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
> joker.eph closed this revision.
> joker.eph marked 2 inline comments as done.
> joker.eph added a comment.
> 
> r255444
> 
> 
> ================
> Comment at: lib/Support/ThreadPool.cpp:139
> @@ +138,3 @@
> +ThreadPool::~ThreadPool() {
> +  EnableFlag = false;
> +  wait();
> ----------------
> tejohnson wrote:
> > Is this just for completeness? It doesn't look like this flag is used when ! LLVM_ENABLE_THREADS.
> It is to silent a compiler warning about "member variable not used" when compiling with LLVM_ENABLE_THREAD=OFF
> 
> Perhaps a more explicit cast to void, or ifdef out the variable instead?

I tried to keep the header clean of ifdef, I can go with a (void) use instead.


— 
Mehdi


>  
> 
> 
> http://reviews.llvm.org/D15464 <http://reviews.llvm.org/D15464>
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151213/bb269351/attachment.html>