<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Dec 13, 2015, at 4:30 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Sat, Dec 12, 2015 at 2:58 PM, Mehdi AMINI via llvm-commits <span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">joker.eph closed this revision.<br class="">
joker.eph marked 2 inline comments as done.<br class="">
joker.eph added a comment.<br class="">
<br class="">
r255444<br class="">
<span class=""><br class="">
<br class="">
================<br class="">
Comment at: lib/Support/ThreadPool.cpp:139<br class="">
@@ +138,3 @@<br class="">
+ThreadPool::~ThreadPool() {<br class="">
+ EnableFlag = false;<br class="">
+ wait();<br class="">
----------------<br class="">
</span><span class="">tejohnson wrote:<br class="">
> Is this just for completeness? It doesn't look like this flag is used when ! LLVM_ENABLE_THREADS.<br class="">
</span>It is to silent a compiler warning about "member variable not used" when compiling with LLVM_ENABLE_THREAD=OFF<br class=""></blockquote><div class=""><br class="">Perhaps a more explicit cast to void, or ifdef out the variable instead?<br class=""></div></div></div></div></div></blockquote><div><br class=""></div><div>I tried to keep the header clean of ifdef, I can go with a (void) use instead.</div><div><br class=""></div><div><br class=""></div><div>— </div><div>Mehdi</div><div><br class=""></div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class=""> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br class="">
<br class="">
<a href="http://reviews.llvm.org/D15464" rel="noreferrer" target="_blank" class="">http://reviews.llvm.org/D15464</a><br class="">
<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
</div></div></blockquote></div><br class=""></div></div>
</div></blockquote></div><br class=""></body></html>