[PATCH] D14822: [mips][microMIPS] Add R_MICROMIPS_PC26_S1 relocation

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 7 07:10:14 PST 2015


dsanders added inline comments.

================
Comment at: lib/Target/Mips/MCTargetDesc/MipsMCCodeEmitter.cpp:370
@@ +369,3 @@
+  const MCExpr *FixupExpression = MCBinaryExpr::createAdd(
+      MO.getExpr(), MCConstantExpr::create(-4, Ctx), Ctx);
+  Fixups.push_back(MCFixup::create(0, FixupExpression,
----------------
Is it still -4 when we're shifting by 1 instead of 2?


http://reviews.llvm.org/D14822





More information about the llvm-commits mailing list