[PATCH] D14822: [mips][microMIPS] Add R_MICROMIPS_PC26_S1 relocation

[Daniel Sanders via llvm-commits]

dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.


================
Comment at: include/llvm/Support/ELFRelocs/Mips.def:111
@@ -110,2 +110,3 @@
 ELF_RELOC(R_MICROMIPS_PC23_S2,          173)
 ELF_RELOC(R_MICROMIPS_PC21_S2,          174)
+ELF_RELOC(R_MICROMIPS_PC26_S1,          175)
----------------
This one ought to be ..._S1 and adjustFixupValue(), etc. should be corrected to match. Could you fix this in a separate patch?

================
Comment at: lib/Target/Mips/MCTargetDesc/MipsAsmBackend.cpp:168
@@ +167,3 @@
+    if (!isInt<26>(Value) && Ctx)
+      Ctx->reportFatalError(Fixup.getLoc(), "out of range PC26 fixup");
+    break;
----------------
We should also 'return 0' as per the other cases.


http://reviews.llvm.org/D14822