[PATCH] D15230: [BranchFolding] Merge MMOs during tail merge

Chad Rosier via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 4 07:29:59 PST 2015


mcrosier added a comment.

In http://reviews.llvm.org/D15230#302403, @flyingforyou wrote:

> Your opinion is not optinal. It's essential. So, I added threshold and set it 255. It's maximum value of MMOs count.
>  After setting threshold, there is no error likes below.
>  http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/21531/steps/annotate/logs/stdio


Hi Junmo,
Would you mind explaining what exactly caused the bootstrap to fail?  I just want to make sure this is in fact the correct fix.  Also, I'm wondering how you arrived at the 255 threshold; I would have probably picked something much smaller (e.g., 16).

Chad

p.s., We should always do the necessary due diligence to prevent breakages, but please don't lose sleep over it. :)  We do appreciate your efforts on this patch!


http://reviews.llvm.org/D15230





More information about the llvm-commits mailing list