[PATCH] D15230: [BranchFolding] Merge MMOs during tail merge

Junmo Park via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 4 07:00:55 PST 2015


flyingforyou added a comment.

Hi, Chad, Geoff.

> In http://reviews.llvm.org/D14797, @gberry wrote:

>  Alternatively, could you just add a bail out case that clears all memops if M1->getMemOperands().size() * M2->getMemOperands().size() is above a certain threshold? That would > > prevent any pathological cases from causing compile time blowups.

> @mcrosier wrote:

> This sounds very reasonable, IMO.

> @flyingforyou wrote:

> I will make an another patch. We can discuss about threshold value.


Your opinion is not optinal. It's essential. So, I added threshold and set it 255. It's maximum value of MMOs count.
After setting threshold, there is no error likes below.
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/21531/steps/annotate/logs/stdio

Could you review this commit again, please?

I am really sorry for hasty decisions.

Junmo.


http://reviews.llvm.org/D15230





More information about the llvm-commits mailing list