[PATCH] D15134: Part 1 to fix x86_64 fp128 calling convention.

[Chih-hung Hsieh via llvm-commits]

On Wed, Dec 2, 2015 at 3:47 PM, Xinliang David Li <davidxl at google.com>
wrote:

> On Wed, Dec 2, 2015 at 3:44 PM, Chih-Hung Hsieh <chh at google.com> wrote:
> > chh added a comment.
> >
> > Sean, only the "Fix printOperand to handle null operand" in
> SelectionDAGDumper.cpp might have some value by itself.
>
> If you can submit the smaller patches independently, it is still
> better to submit them separately  -- it reduces the chances of build
> breaks.
>
>
One small change is less risky than one large change, but
it's unclear to me that the total number of broken builds (downtime)
can be reduced by breaking a 10-file patch into 10 1-file patches.

If there are K errors, they will break builds K times
if we discover and fix them one by one.
The hope is to find error before submitting file #2 from the
regression of submitted file #1. But it seems more likely
to discover both errors in #1 and #2 when they are submitted together
and then reverted and fixed together.

-- chh




> David
>
>
> > All other changes are not useful before x86_64 f128 type is configured
> to fix the calling convention problem.
> > This part 1 change should have no impact at all before the rest of
> http://reviews.llvm.org/D11438 is merged in.
> > Getting this part 1 in first is just to check for any regression.
> > I think all these changes should go in or be reverted when necessary.
> > It would be easier to keep track of these changes together, right?
>
>
>
>
> >
> >
> > http://reviews.llvm.org/D15134
> >
> >
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151202/97be4ed9/attachment.html>