[PATCH] D15134: Part 1 to fix x86_64 fp128 calling convention.

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 2 15:47:47 PST 2015


On Wed, Dec 2, 2015 at 3:44 PM, Chih-Hung Hsieh <chh at google.com> wrote:
> chh added a comment.
>
> Sean, only the "Fix printOperand to handle null operand" in SelectionDAGDumper.cpp might have some value by itself.

If you can submit the smaller patches independently, it is still
better to submit them separately  -- it reduces the chances of build
breaks.

David


> All other changes are not useful before x86_64 f128 type is configured to fix the calling convention problem.
> This part 1 change should have no impact at all before the rest of http://reviews.llvm.org/D11438 is merged in.
> Getting this part 1 in first is just to check for any regression.
> I think all these changes should go in or be reverted when necessary.
> It would be easier to keep track of these changes together, right?




>
>
> http://reviews.llvm.org/D15134
>
>
>


More information about the llvm-commits mailing list