[llvm] r254238 - [SimplifyLibCalls] Fix inverted condition that lead to an uninitialized memory read below.

Benjamin Kramer via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 28 13:43:13 PST 2015


Author: d0k
Date: Sat Nov 28 15:43:12 2015
New Revision: 254238

URL: http://llvm.org/viewvc/llvm-project?rev=254238&view=rev
Log:
[SimplifyLibCalls] Fix inverted condition that lead to an uninitialized memory read below.

Found by msan!

Modified:
    llvm/trunk/lib/Transforms/Utils/SimplifyLibCalls.cpp

Modified: llvm/trunk/lib/Transforms/Utils/SimplifyLibCalls.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/SimplifyLibCalls.cpp?rev=254238&r1=254237&r2=254238&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Utils/SimplifyLibCalls.cpp (original)
+++ llvm/trunk/lib/Transforms/Utils/SimplifyLibCalls.cpp Sat Nov 28 15:43:12 2015
@@ -1454,8 +1454,8 @@ LibCallSimplifier::classifyArgUse(Value
 
   Function *Callee = CI->getCalledFunction();
   LibFunc::Func Func;
-  if (Callee && (!TLI->getLibFunc(Callee->getName(), Func) || !TLI->has(Func) ||
-                 !isTrigLibCall(CI)))
+  if (!Callee || !TLI->getLibFunc(Callee->getName(), Func) || !TLI->has(Func) ||
+      !isTrigLibCall(CI))
     return;
 
   if (IsFloat) {




More information about the llvm-commits mailing list