[PATCH] D11768: FastISel fails to remove dead code

Wolfgang Pieb via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 20 17:20:04 PST 2015


wolfgangp updated this revision to Diff 40850.
wolfgangp added a comment.

Sorry, Eric, I had to revise the patch because we found another instance of this issue, in that handlePHINodesInSuccessorBlocks() can return false AND leave dead code behind, so I ended up breaking out the removing code and calling it from two different places. The test case has 2 subcases covering both code paths.

I beefed up the commentary a bit.


http://reviews.llvm.org/D11768

Files:
  include/llvm/CodeGen/FastISel.h
  lib/CodeGen/SelectionDAG/FastISel.cpp
  test/CodeGen/X86/fast-isel-deadcode.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11768.40850.patch
Type: text/x-patch
Size: 8961 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151121/c097854f/attachment.bin>


More information about the llvm-commits mailing list