[PATCH] D11768: FastISel fails to remove dead code

[Eric Christopher via llvm-commits]

echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

One inline comment requesting more commenting :)

Otherwise LGTM.

Thanks!

-eric


================
Comment at: lib/CodeGen/SelectionDAG/FastISel.cpp:1392-1396
@@ +1391,7 @@
+    if (CurLastLocalValue != SavedLastLocalValue) {
+      MachineBasicBlock::iterator FirstDeadInst(SavedLastLocalValue);
+      if (SavedLastLocalValue)
+        ++FirstDeadInst;
+      else
+        FirstDeadInst = FuncInfo.MBB->getFirstNonPHI();
+      setLastLocalValue(SavedLastLocalValue);
----------------
This feels a little weird, can you comment it a bit?


http://reviews.llvm.org/D11768