[PATCH] D14380: [ARM] Combine BFIs together

[James Molloy via llvm-commits]

... yes, you're right of course.

On Wed, 11 Nov 2015 at 13:24 silviu.baranga at arm.com via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> sbaranga added inline comments.
>
> ================
> Comment at: lib/Target/ARM/ARMISelLowering.cpp:9067
> @@ +9066,3 @@
> +    APInt NewToMask, NewFromMask;
> +    SDValue NewFrom = ParseBFI(V.getNode(), NewToMask, NewFromMask);
> +    if (NewFrom != From) {
> ----------------
> jmolloy wrote:
> > I thought about it again and there's nothing stopping us looking through
> a BFI with a different base.
> Ok, but I think we still need to set the CombinedToMask in this case
> (otherwise we might not detect some conflicts).
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D14380
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151111/a2d698c0/attachment.html>