<div dir="ltr">... yes, you're right of course.</div><br><div class="gmail_quote"><div dir="ltr">On Wed, 11 Nov 2015 at 13:24 <a href="mailto:silviu.baranga@arm.com">silviu.baranga@arm.com</a> via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">sbaranga added inline comments.<br>
<br>
================<br>
Comment at: lib/Target/ARM/ARMISelLowering.cpp:9067<br>
@@ +9066,3 @@<br>
+    APInt NewToMask, NewFromMask;<br>
+    SDValue NewFrom = ParseBFI(V.getNode(), NewToMask, NewFromMask);<br>
+    if (NewFrom != From) {<br>
----------------<br>
jmolloy wrote:<br>
> I thought about it again and there's nothing stopping us looking through a BFI with a different base.<br>
Ok, but I think we still need to set the CombinedToMask in this case (otherwise we might not detect some conflicts).<br>
<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="http://reviews.llvm.org/D14380" rel="noreferrer" target="_blank">http://reviews.llvm.org/D14380</a><br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>