HA: [PATCH] D13904: [ELF2] .shstrtab section implemented

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 20 10:46:02 PDT 2015


Yes, that is my primary dev tool.
I am using qtcreator and ubuntu virtual machine only for self-hosting tests and to have access to gnu tools when needed.
It works for me.
________________________________________
От: Rui Ueyama [ruiu at google.com]
Отправлено: 20 октября 2015 г. 21:41
Кому: reviews+D13904+public+03561865476a15e1 at reviews.llvm.org
Копия: George Rimar; Rafael Ávila de Espíndola; Davide Italiano; llvm-commits
Тема: Re: [PATCH] D13904: [ELF2] .shstrtab section implemented

On Tue, Oct 20, 2015 at 10:27 AM, George Rimar <grimar at accesssoftek.com<mailto:grimar at accesssoftek.com>> wrote:
grimar added a comment.

In http://reviews.llvm.org/D13904#271253, @ruiu wrote:

> Also please verify that the patch does not contain trailing whitespace. (I don't know if that exists in this patch, but your previous patch contained that.) If you are using git, the easiest way is to run 'git show' before submission, as the command highlights trailing whitespace.


I noticed your message too late. Actually I am using svn, but I had installed plugin for MSVS that keeps unix endlines in code, so I hope everything should be fine here.

Out of curiosity, by MSVS, you mean Microsoft Visual Studio? (I mean, nothing wrong with MSVS, but I assumed that Unix tool developers are usually using Unix.)


More information about the llvm-commits mailing list