[PATCH] D13904: [ELF2] .shstrtab section implemented

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 20 10:41:42 PDT 2015


On Tue, Oct 20, 2015 at 10:27 AM, George Rimar <grimar at accesssoftek.com>
wrote:

> grimar added a comment.
>
> In http://reviews.llvm.org/D13904#271253, @ruiu wrote:
>
> > Also please verify that the patch does not contain trailing whitespace.
> (I don't know if that exists in this patch, but your previous patch
> contained that.) If you are using git, the easiest way is to run 'git show'
> before submission, as the command highlights trailing whitespace.
>
>
> I noticed your message too late. Actually I am using svn, but I had
> installed plugin for MSVS that keeps unix endlines in code, so I hope
> everything should be fine here.


Out of curiosity, by MSVS, you mean Microsoft Visual Studio? (I mean,
nothing wrong with MSVS, but I assumed that Unix tool developers are
usually using Unix.)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151020/22a7606f/attachment.html>


More information about the llvm-commits mailing list