[PATCH] D13436: AMDGPU/SI: Add 64-bit versions of v_nop and v_clrexcp

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 5 08:52:57 PDT 2015


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: lib/Target/AMDGPU/SIInstrFormats.td:72
@@ -70,2 +71,3 @@
   let TSFlags{21} = VGPRSpill;
+  let TSFlags{22} = VOPAsmPrefer32Bit;
 
----------------
This could use a comment explaining it

================
Comment at: lib/Target/AMDGPU/SIInstructions.td:1163
@@ -1162,3 +1162,3 @@
 
 let isMoveImm = 1, isReMaterializable = 1, isAsCheapAsAMove = 1 in {
 defm V_MOV_B32 : VOP1Inst <vop1<0x1>, "v_mov_b32", VOP_I32_I32>;
----------------
Should it also be set here for v_mov_b32?


http://reviews.llvm.org/D13436





More information about the llvm-commits mailing list