[PATCH] D12298: Revert two bad commits.

[David Blaikie via llvm-commits]

Generally we try not to send out code reviews unless there's an expectation
that review is required/desired.

Seeing something sent for review, then committed without any sign off can
be problematic. (some people send things for review then say things like
"if no one says anything bad about this in <time period> I'll commit" which
is generally seen as poor form - either it needs review, in which case time
doesn't change that fact, or it doesn't & shouldn't be sent for review in
the first place)

On Mon, Aug 24, 2015 at 3:08 PM, JF Bastien via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> jfb created this revision.
> jfb added a subscriber: llvm-commits.
> Herald added a subscriber: jfb.
>
> I forgot to squash git commits before doing an svn dcommit of D12219.
> Reverting, and re-submitting.
>
> http://reviews.llvm.org/D12298
>
> Files:
>   lib/Target/WebAssembly/InstPrinter/WebAssemblyInstPrinter.cpp
>   lib/Target/WebAssembly/InstPrinter/WebAssemblyInstPrinter.h
>   lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp
>   lib/Target/WebAssembly/WebAssemblyISD.def
>   lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
>   lib/Target/WebAssembly/WebAssemblyISelLowering.h
>   lib/Target/WebAssembly/WebAssemblyInstrCall.td
>   lib/Target/WebAssembly/WebAssemblyInstrFormats.td
>   test/CodeGen/WebAssembly/call.ll
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150824/5b203660/attachment.html>