<div dir="ltr">Generally we try not to send out code reviews unless there's an expectation that review is required/desired.<br><br>Seeing something sent for review, then committed without any sign off can be problematic. (some people send things for review then say things like "if no one says anything bad about this in <time period> I'll commit" which is generally seen as poor form - either it needs review, in which case time doesn't change that fact, or it doesn't & shouldn't be sent for review in the first place)</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 24, 2015 at 3:08 PM, JF Bastien via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">jfb created this revision.<br>
jfb added a subscriber: llvm-commits.<br>
Herald added a subscriber: jfb.<br>
<br>
I forgot to squash git commits before doing an svn dcommit of D12219. Reverting, and re-submitting.<br>
<br>
<a href="http://reviews.llvm.org/D12298" rel="noreferrer" target="_blank">http://reviews.llvm.org/D12298</a><br>
<br>
Files:<br>
  lib/Target/WebAssembly/InstPrinter/WebAssemblyInstPrinter.cpp<br>
  lib/Target/WebAssembly/InstPrinter/WebAssemblyInstPrinter.h<br>
  lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp<br>
  lib/Target/WebAssembly/WebAssemblyISD.def<br>
  lib/Target/WebAssembly/WebAssemblyISelLowering.cpp<br>
  lib/Target/WebAssembly/WebAssemblyISelLowering.h<br>
  lib/Target/WebAssembly/WebAssemblyInstrCall.td<br>
  lib/Target/WebAssembly/WebAssemblyInstrFormats.td<br>
  test/CodeGen/WebAssembly/call.ll<br>
<br>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>