[lld] r245676 - COFF: Fix /lldmap option.

[David Blaikie via llvm-commits]

On Fri, Aug 21, 2015 at 12:01 AM, Rui Ueyama via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: ruiu
> Date: Fri Aug 21 02:01:08 2015
> New Revision: 245676
>
> URL: http://llvm.org/viewvc/llvm-project?rev=245676&view=rev
> Log:
> COFF: Fix /lldmap option.
>
> isLive returns false if it's not COMDAT, so check for that condition.
>

Is this already tested? (was this to fix a failing test - or does it need a
new test?)


>
> Modified:
>     lld/trunk/COFF/SymbolTable.cpp
>
> Modified: lld/trunk/COFF/SymbolTable.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/SymbolTable.cpp?rev=245676&r1=245675&r2=245676&view=diff
>
> ==============================================================================
> --- lld/trunk/COFF/SymbolTable.cpp (original)
> +++ lld/trunk/COFF/SymbolTable.cpp Fri Aug 21 02:01:08 2015
> @@ -325,7 +325,7 @@ void SymbolTable::printMap(llvm::raw_ost
>      OS << File->getShortName() << ":\n";
>      for (SymbolBody *Body : File->getSymbols())
>        if (auto *R = dyn_cast<DefinedRegular>(Body))
> -        if (R->isLive())
> +        if (!R->isCOMDAT() || R->isLive())
>            OS << Twine::utohexstr(Config->ImageBase + R->getRVA())
>               << " " << R->getName() << "\n";
>    }
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150821/bd82829c/attachment.html>