<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Aug 21, 2015 at 12:01 AM, Rui Ueyama via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ruiu<br>
Date: Fri Aug 21 02:01:08 2015<br>
New Revision: 245676<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=245676&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=245676&view=rev</a><br>
Log:<br>
COFF: Fix /lldmap option.<br>
<br>
isLive returns false if it's not COMDAT, so check for that condition.<br></blockquote><div><br></div><div>Is this already tested? (was this to fix a failing test - or does it need a new test?)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
    lld/trunk/COFF/SymbolTable.cpp<br>
<br>
Modified: lld/trunk/COFF/SymbolTable.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/SymbolTable.cpp?rev=245676&r1=245675&r2=245676&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/SymbolTable.cpp?rev=245676&r1=245675&r2=245676&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/COFF/SymbolTable.cpp (original)<br>
+++ lld/trunk/COFF/SymbolTable.cpp Fri Aug 21 02:01:08 2015<br>
@@ -325,7 +325,7 @@ void SymbolTable::printMap(llvm::raw_ost<br>
     OS << File->getShortName() << ":\n";<br>
     for (SymbolBody *Body : File->getSymbols())<br>
       if (auto *R = dyn_cast<DefinedRegular>(Body))<br>
-        if (R->isLive())<br>
+        if (!R->isCOMDAT() || R->isLive())<br>
           OS << Twine::utohexstr(Config->ImageBase + R->getRVA())<br>
              << " " << R->getName() << "\n";<br>
   }<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>