[PATCH] D11660: [x86] reassociate integer multiplies using machine combiner pass

[Sanjay Patel]

spatel added inline comments.

================
Comment at: lib/Target/X86/X86InstrInfo.cpp:6506
@@ -6485,3 +6505,3 @@
       .addReg(RegY, getKillRegState(KillY));
   InsInstrs.push_back(MIB1);
 
----------------
spatel wrote:
> Is it ok that I'm not explicitly adding a dead EFLAGS operand (if this is an integer instruction)? I see that the operand gets added later anyway based on the instruction type, but I wonder if it's poor form to not do it right here.
For future reference: I stepped through this in the debugger, and the EFLAGS implicit operand is added when the instruction is created, so there does not appear to be any need to do this explicitly.


http://reviews.llvm.org/D11660