[PATCH] D11660: [x86] reassociate integer multiplies using machine combiner pass

Gerolf Hoflehner ghoflehner at apple.com
Thu Jul 30 18:53:27 PDT 2015


Gerolf accepted this revision.
Gerolf added a comment.

The machine code verifier used the isDead flag, so my assumption would be that it is safe to assume it is set correctly at the point of use in this code.  If there is a way to assert this that would be even better.


================
Comment at: lib/Target/X86/X86InstrInfo.cpp:6309
@@ -6307,2 +6308,3 @@
 
-  // We need virtual register definitions.
+  // Integer binary math/logic instructions have a third source operand:
+  // the EFLAGS register. That operand must be both defined here and never
----------------
Thanks for the clarification.


http://reviews.llvm.org/D11660







More information about the llvm-commits mailing list