[PATCH] D11491: [Polly] Move computations out of constructors

[Tobias Grosser]

grosser added a comment.

Hi Michael,

just a vector of ScopStmt pointers is what we had before and we moved away of this for memory safety reasons (see discussion '[polly] r238090 - Use unique_ptr to clarify ownership of ScopStmt' on llvm-commits). I agree with Johannes, that we should not add new hacks to move out computations from the constructor and also don't think that having both public factor methods and public (partial) constructors is better than what we have now.However,  I also have currently a good suggestion of how to do it better.

The islAst part seems non-controversial. Feel free to commit it if you like. Also, maybe add some comments into the header.


http://reviews.llvm.org/D11491