[PATCH] D11491: [Polly] Move computations out of constructors

Johannes Doerfert doerfert at cs.uni-saarland.de
Mon Jul 27 06:22:30 PDT 2015


jdoerfert added a subscriber: jdoerfert.
jdoerfert added a comment.

I'm not sure about the whole "moving code out of constructors" part [1] but I am sure about two things:

1. It is not worth it to introduce things one would call "dirty tricks".
2. Introducing explicit memory managment or pointers to objects that are allocated at different places is always error prone. Our forward_lists and vectors with emplaced objects might not be the best solution but at least easy to reason about wrt. memory.

[1] I never experience any of the claimed problems hence I do not see the need for a change. However, if the new code/interface is at least as clean as the current one I do not see a problem either.


http://reviews.llvm.org/D11491







More information about the llvm-commits mailing list