[PATCH] D11445: [zorg] Add lldb build factory that launches scripts on slave machine

[Ying Chen]

chying added inline comments.

================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:923
@@ +922,3 @@
+    getShellCommandStep(f, name='clean up',
+                        command=['cleanUp.bat'],
+                        haltOnFailure=False)
----------------
chaoren wrote:
> Is this for both Linux/OS X and Windows? On Linux/OS X, *.sh might be more appropriate. You can add another argument called 'scriptExtension' or something.
Yes, this factory should work for all host platforms.
Will use different extensions.

================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:926
@@ +925,3 @@
+
+    # Get lldb-server binaries
+    if not buildAndroid:
----------------
chaoren wrote:
> We don't need this until we start testing. Could you move this between build and test?
I was thinking if this revision of binaries doesn't exist, then the build will terminate from here.
This might happen when the build is not triggered by buildserver, like when user click Force Build from webpage.

================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:943
@@ +942,3 @@
+
+    # Configure
+    getShellCommandStep(f, name='cmake local',
----------------
chaoren wrote:
> We can probably condense cleanup, checkout, and configure into one configure script. I don't think the first two steps would be useful to see separately.
We had some build failures with source checkout due to SVN server issue.
How about combine cleanup and checkout? 


http://reviews.llvm.org/D11445